MODINVSTOR-1262 Merge ecs-tlr-feature into master #1113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…1010) * MODINVSTOR-1179 Add ecsRequestRouting field to service point schema * MODINVSTOR-1179 Add ecsRequestRouting field to service point schema * MODINVSTOR-1179 Add ecsRequestRouting field to service point schema * MODINVSTOR-1179 Bump service-point.raml version --------- Co-authored-by: alexanderkurash <[email protected]>
* MODINVSTOR-1219 Do not return routing service points by default * MODINVSTOR-1219 Fix formatting * MODINVSTOR-1219 Extend test * MODINVSTOR-1219 Update query parameter description * MODINVSTOR-1219 Fix checkstyle violations * MODINVSTOR-1219 Test refactoring * MODINVSTOR-1219 Test refactoring * MODINVSTOR-1219 Put filter in front of original query, update tests * MODINVSTOR-1219 Minor refactoring
# Conflicts: # NEWS.md
…t events (#1088) * MODINVSTOR-1245: Implement synchronization operation for service point event * MODINVSTOR-1245: Fix from code review * MODINVSTOR-1245: Comply with check style * MODINVSTOR-1245: Comply with check style * MODINVSTOR-1245: Add api test * MODINVSTOR-1245: Rename service point event * MODINVSTOR-1245: Rename tests * MODINVSTOR-1245: Replace service point creation with service implementation * MODINVSTOR-1245: Add validation for hold shelf expiry and pick up location * MODINVSTOR-1245: Replace system-stubs-junit4 instead of hard-coded env variable * MODINVSTOR-1245: Fix from code review * MODINVSTOR-1245: Fix from code review * MODINVSTOR-1245: Add logs
…nto ecs-tlr-feature # Conflicts: # pom.xml
alexanderkurash
requested review from
psmagin,
viacheslavkol,
mukhiddin-yusuf and
SvitlanaKovalova1
psmagin
requested changes
Nov 5, 2024
| @@ -2900,7 +2900,8 @@ | |||
| { "name": "S3_BUCKET", "value": "marc-migrations" }, | |||
| { "name": "S3_ACCESS_KEY_ID", "value": "" }, | |||
| { "name": "S3_SECRET_ACCESS_KEY", "value": "" }, | |||
| { "name": "S3_IS_AWS", "value": "true" } | |||
| { "name": "S3_IS_AWS", "value": "true" }, | |||
| { "name": "ECS_TLR_FEATURE_ENABLED", "value": "false"} | |||
There was a problem hiding this comment.
Please document it in README
pom.xml
Outdated
| @@ -37,6 +37,8 @@ | |||
| <rest-assured.version>5.5.0</rest-assured.version> | |||
| <awaitility.version>4.2.2</awaitility.version> | |||
| <assertj.version>3.26.3</assertj.version> | |||
| <localstack.version>1.20.1</localstack.version> | |||
There was a problem hiding this comment.
Can't see where it is used.
| import org.folio.services.consortium.handler.ServicePointSynchronizationUpdateHandler; | ||
| import org.folio.services.domainevent.ServicePointEventType; | ||
|
|
||
| public class ServicePointSynchronizationVerticle extends AbstractVerticle { |
There was a problem hiding this comment.
There is already existing SynchronizationVerticle that would be nice to utilize instead of creating an additional one.
There was a problem hiding this comment.
Create this tech debt ticket for refactoring https://folio-org.atlassian.net/browse/MODINVSTOR-1285
…storage into ecs-tlr-feature # Conflicts: # pom.xml
roman-barannyk
force-pushed
the
ecs-tlr-feature
branch
2 times, most recently
from
e823d77 to
258f166
Compare
roman-barannyk
force-pushed
the
ecs-tlr-feature
branch
from
258f166 to
89c4bfe
Compare
roman-barannyk
force-pushed
the
ecs-tlr-feature
branch
from
7369163 to
dd0f4ef
Compare
roman-barannyk
force-pushed
the
ecs-tlr-feature
branch
from
bc75e20 to
1f8da1b
Compare
roman-barannyk
approved these changes
Nov 11, 2024
psmagin
reviewed
Nov 12, 2024
NEWS.md
Outdated
| @@ -52,6 +52,11 @@ | |||
| ### Features | |||
| * Add floating collection flag in location schema ([MODINVSTOR-1250](https://issues.folio.org/browse/MODINVSTOR-1250)) | |||
| * Implement domain event production for location create/update/delete ([MODINVSTOR-1181](https://issues.folio.org/browse/MODINVSTOR-1181)) | |||
| * Merge custom ECS TLR feature branch into master ([MODINVSTOR-1262](https://folio-org.atlassian.net/browse/MODINVSTOR-1262)) | |||
There was a problem hiding this comment.
It's already released version. Please move it to not-released version block
There was a problem hiding this comment.
Moved to v28.1.0 YYYY-mm-DD / Features
psmagin
approved these changes
Nov 12, 2024
|
roman-barannyk
pushed a commit
that referenced
this pull request
Dec 1, 2024
* MODINVSTOR-1179 Add ecsRequestRouting field to service point schema (#1010) * MODINVSTOR-1179 Add ecsRequestRouting field to service point schema * MODINVSTOR-1179 Add ecsRequestRouting field to service point schema * MODINVSTOR-1179 Add ecsRequestRouting field to service point schema * MODINVSTOR-1179 Bump service-point.raml version --------- Co-authored-by: alexanderkurash <[email protected]> * MODINVSTOR-1219: Do not return routing service points by default (#1022) * MODINVSTOR-1219 Do not return routing service points by default * MODINVSTOR-1219 Fix formatting * MODINVSTOR-1219 Extend test * MODINVSTOR-1219 Update query parameter description * MODINVSTOR-1219 Fix checkstyle violations * MODINVSTOR-1219 Test refactoring * MODINVSTOR-1219 Test refactoring * MODINVSTOR-1219 Put filter in front of original query, update tests * MODINVSTOR-1219 Minor refactoring * MODINVSTOR-1245: Implement synchronization operation for service point events (#1088) * MODINVSTOR-1245: Implement synchronization operation for service point event * MODINVSTOR-1245: Fix from code review * MODINVSTOR-1245: Comply with check style * MODINVSTOR-1245: Comply with check style * MODINVSTOR-1245: Add api test * MODINVSTOR-1245: Rename service point event * MODINVSTOR-1245: Rename tests * MODINVSTOR-1245: Replace service point creation with service implementation * MODINVSTOR-1245: Add validation for hold shelf expiry and pick up location * MODINVSTOR-1245: Replace system-stubs-junit4 instead of hard-coded env variable * MODINVSTOR-1245: Fix from code review * MODINVSTOR-1245: Fix from code review * MODINVSTOR-1245: Add logs * Fix mockConsortiumTenants after merge * Disable canRequestOaiPmhViewWhenEmptyDb test * MODINVSTOR-1262 Re-enable disabled tests * MODINVSTOR-1262 Update NEWS * MODINVSTOR-1262 Remove unneeded dependency * MODINVSTOR-1262 improve test coverage, update readme * MODINVSTOR-1262 improve test coverage * MODINVSTOR-1262 improve test coverage * MODINVSTOR-1262 improve test coverage * MODINVSTOR-1262 add missing permission * MODINVSTOR-1262 add test coverage * MODINVSTOR-1262 add test coverage * MODINVSTOR-1262 fix code smell * MODINVSTOR-1262 fix code smell * MODINVSTOR-1262 Move ECS TLR news to In progress --------- Co-authored-by: Magzhan <[email protected]> Co-authored-by: OleksandrVidinieiev <[email protected]> Co-authored-by: Oleksandr Vidinieiev <[email protected]> Co-authored-by: Maksat <[email protected]> Co-authored-by: Roman_Barannyk <[email protected]> Co-authored-by: Roman Barannyk <[email protected]> (cherry picked from commit 810764f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
MODINVSTOR-1262
Includes all changes from the ECS TLR feature UXPROD-4559:
MODINVSTOR-1179
MODINVSTOR-1219
MODINVSTOR-1245
MODINVSTOR-1246